[Windows] Add CI wheel build jobs for Windows #13837
Conversation
GregoryComer
requested review from
jackzhxng,
kirklandsign,
larryliu0820 and
lucylq
as code owners
|
Finally have green CI. I'm rebasing and re-running CI, but it should be ready for review. |
| @@ -0,0 +1,75 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
This test logic is intentionally different from the Linux/Mac logic. This is due to needing a bunch of additional environment setup in the job for native build. This Windows test logic is actually a bit more comprehensive, as it uses pybindings and verifies model outputs (vs just running the exported model on the native runner and ensuring it doesn't crash). I'd like to come back and update the other logic post-GA.
| # Otherwise, flatc will target the project's toolchain (i.e. iOS, or Android). | ||
| ExternalProject_Add( | ||
| flatbuffers_ep | ||
| PREFIX ${CMAKE_CURRENT_BINARY_DIR}/flatc_proj |
There was a problem hiding this comment.
More path length workarounds.
Yeah, thanks. See the Build Windows Wheels jobs. I'll double-check the resultant wheel one more time locally, but it should be good to go. |
GregoryComer
removed
the
release notes: none
Set up wheel build jobs for Windows (x86-64). This is derived from the torchvision build setup (see https://github.com/pytorch/vision/blob/b208f7f4125e8a9a51638549ccf3e9b163f53dda/.github/workflows/build-wheels-windows.yml#L4).
3 participants
Set up wheel build jobs for Windows (x86-64). This is derived from the torchvision build setup (see https://github.com/pytorch/vision/blob/b208f7f4125e8a9a51638549ccf3e9b163f53dda/.github/workflows/build-wheels-windows.yml#L4).